BREAKING(assert): make unreachable()
consistent with @std/assert
#4943
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed
This change changes the format of the error message thrown in
unreachable()
to consistent with the rest of@std/assert
. It also capitalizes the first letter of the error message.Why this change was made
Previously, the format of the error message
unreachable()
threw didn't have the message suffix, given by themsg
argument, at the end of the message string, which is what the rest of@std/assert
. This change was made for consistency.Migration guide
To migrate, update the logic that handles the error message: